8 replies to this topic

[iphoneiv]

hellos, i just need a little help with picking up and placing down items

i can pick an item up and put it down, but i can't seem to be able to pick the item up again (the second time)

codes:

item(that i will hold):
step:

Spoiler

if keyboard_check(ord('X')){
if o_player.carrying=1 && o_player.face_dir="up"
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+2);
y=round(o_player.y-33);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="down"
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+2);
y=round(o_player.y-23);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="left"
{
depth=o_player.depth-1
solid=0
x=round(o_player.x-6);
y=round(o_player.y-29);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="right"
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+6);
y=round(o_player.y-29);
move_towards_point(o_player.x,o_player.y,12)
break;
}
}

Spoiler

else{
if o_player.carrying=1 && o_player.face_dir="up" && keyboard_check(vk_up)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+1);
y=round(o_player.y-33);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="down" && keyboard_check(vk_down)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+2);
y=round(o_player.y-29);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="left" && keyboard_check(vk_left)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x-4);
y=round(o_player.y-30);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="right" && keyboard_check(vk_right)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+4);
y=round(o_player.y-30);
move_towards_point(o_player.x,o_player.y,12)
break;
}
}

Spoiler

if o_player.carrying=1 && o_player.face_dir="up" && !keyboard_check(vk_up)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+1);
y=round(o_player.y-32);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="down" && !keyboard_check(vk_down)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x+1);
y=round(o_player.y-31);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="left" && !keyboard_check(vk_left)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x);
y=round(o_player.y-30);
move_towards_point(o_player.x,o_player.y,12)
break;
}
if o_player.carrying=1 && o_player.face_dir="right" && !keyboard_check(vk_right)
{
depth=o_player.depth-1
solid=0
x=round(o_player.x);
y=round(o_player.y-30);
move_towards_point(o_player.x,o_player.y,12)
break;
}

if o_player.carrying=0
x=o_46.x
y=o_46.y



if (o_player.liftRTimer==10){
instance_destroy()
}

press 'Z':

Spoiler

if global.pause = false and scr_checknear(o_player) && o_player.carrying=0 && o_player.ready=1
{
o_player.lift=1
}

player:
create:

Spoiler

lift=0
carrying=0
liftTimer=12
downTimer=0
putDown=0
ready=1
liftReverse=0
liftRTimer=12

step:

Spoiler

if lift=1
{
if face_dir="down"{
sprite_index=liftD
liftTimer-=1}
if face_dir="up"{
sprite_index=liftU
liftTimer-=1}
if face_dir="left"{
sprite_index=liftL
liftTimer-=1}
if face_dir="right"{
sprite_index=liftR
liftTimer-=1}
}

Spoiler

if (liftTimer==2)
{
ready=0
carrying=1
}

if (liftTimer==0)
lift=0

if lift=0
liftTimer=12

Spoiler

if carrying=1 && spd=2{
if face_dir="up"
{
sprite_index=carryU
}
if face_dir="down"
{
sprite_index=carryD
}
if face_dir="left"
{
sprite_index=carryL
}
if face_dir="right"
{
sprite_index=carryR
}
}

if carrying=1 && spd=4{
if face_dir="up"
{
sprite_index=carry_runU
}
if face_dir="down"
{
sprite_index=carry_runD
}
if face_dir="left"
{
sprite_index=carry_runL
}
if face_dir="right"
{
sprite_index=carry_runR
}
}

Spoiler

if carrying=1 && keyboard_check_pressed(ord('Z')) && ready=0 && global.pause = false
{
carrying=0
liftReverse=1
}

Spoiler

if liftReverse=1 && carrying=0
{
if face_dir="down"{
sprite_index=liftRD
liftRTimer-=1}
if face_dir="up"{
sprite_index=liftRU
liftRTimer-=1}
if face_dir="left"{
sprite_index=liftRL
liftRTimer-=1}
if face_dir="right"{
sprite_index=liftRR
liftRTimer-=1}
}

Spoiler

if (liftRTimer==2)
ready=1

Spoiler

if (liftRTimer==1){

if face_dir="down"{
instance_create(o_player.x,o_player.y+10,o_46)
o_46.solid=1
o_46.depth=o_player.depth+1
}
if face_dir="up"{
instance_create(o_player.x,o_player.y-10,o_46)

o_46.solid=1
o_46.depth=o_player.depth+1
}
if face_dir="left"{
instance_create(o_player.x-10,o_player.y,o_46)

o_46.solid=1
o_46.depth=o_player.depth+1
}
if face_dir="right"{
instance_create(o_player.x+10,o_player.y,o_46)

o_46.solid=1
o_46.depth=o_player.depth+1
}
}

Spoiler

if (liftRTimer==0)
{
liftReverse=0
}

if liftReverse=0
liftRTimer=12

Spoiler

if carrying=0 && liftReverse=0{
if face_dir="down"
if sprite_index=liftRD
sprite_index=spr_pdown

if face_dir="up"
if sprite_index=liftRU
sprite_index=spr_pup

if face_dir="left"
if sprite_index=liftRL
sprite_index=spr_pleft

if face_dir="right"
if sprite_index=liftRR
sprite_index=spr_pright}

- yes, they are mostly in step event
i'm not all that experienced as you can tell


the way how i want it to be is like in zelda(the way he picks up and places down)
although in zelda games, he throws the item; i want the player to place it in front of him

i'm sorry for the longness and messiness of it all but i was doing all this in a hurry since i'm going somewhere very soon
-btw, if i made any stupid mistakes, please feel free to point them out
(i'm sure there's alot :>, unfortunately)

if there's anyting else that you need o know, jst ask
any pointers/hints would be awesome, thx (edit:just got back :D)

EDIT: also, if there's another waaaaaaaaaaaaaaaaaay easier way to do the same thing i'm trying to do, i'll be glad to hear it ^^
i want to be able to use this code so that i can pick up and drop many items, not just one specific one(not all items at once, but individually)

Edited by iphoneiv, 04 March 2012 - 07:31 PM.

[greep]

Whoo, if you put each block in spoilers with a label before each I'll read it when you get back.

[iphoneiv]

Whoo, if you put each block in spoilers with a label before each I'll read it when you get back.

i'm back, and i've put them in spoiler tags...still pretty long though, me is very sorry :<
hopefully i'll find what's going wrong with this
and btw, thx, ur the only one who replied, lol
(probably because the codes were way too long)

[greep]

Okay, thta's still a lot of code lol. Okay I'll keep reading but in the meantime, I'm guessing one of these variables:

lift=0
carrying=0
liftTimer=12
downTimer=0
putDown=0
ready=1
liftReverse=0
liftRTimer=12


is not what you want at the time you pickup/drop the item. Do some debugging with at runtime by doing this

(in a key press event of some cheat code button)

theCheat = get_string("CHEAT","")
execute_string(theCheat)

and type in the box show_message(string(theNameOfTheVariableYouWantToTest))

For several variables. Chances are one of them is set to true or false or something and you don't want it to be.

[iphoneiv]

Okay, thta's still a lot of code lol. Okay I'll keep reading but in the meantime, I'm guessing one of these variables:

lift=0
carrying=0
liftTimer=12
downTimer=0
putDown=0
ready=1
liftReverse=0
liftRTimer=12


is not what you want at the time you pickup/drop the item. Do some debugging with at runtime by doing this

(in a key press event of some cheat code button)

theCheat = get_string("CHEAT","")
execute_string(theCheat)

and type in the box show_message(string(theNameOfTheVariableYouWantToTest))

For several variables. Chances are one of them is set to true or false or something and you don't want it to be.

> i checked the variable values and such in the debug mode, but apparently the problem doesn't lie in the variables

i tried to constantly pres 'z' while walking all over the item, and i found that i can lift the item sometimes
dunno y tho OnO

- it might have to do with when the chracter creates the item (after the item was deleted)

EDIT: actually, i think it really does have to do with creating them
when i put the instance create x and y to the player's, i can lift them up any time, but if i put the x and y into the player's +15(or something) then it doesnt work
it probably has to be right in the middle of the little boxes of the grid on the map
i just dunno how to place it in the middle and go in front of the player

Edited by iphoneiv, 04 March 2012 - 03:20 AM.

[greep]

Hrm, if it's not the variables. Hrm.. how exactly does scr_checknear work?

[FoxInABox]

may I suggest that you just give all items that can be picked up the same parent item..

and instead of all the code in the item you can delete the item in front and store the object type and sprite in player, so that player just draw it at the rigth place depending on the action.. when placement action is done you create it in front and clear your variables.

instance_create(o_player.x,o_player.y-10,o_46)

o_46.solid=1
o_46.depth=o_player.depth+1

note that writing object_name.variable will affect only the first o_46 that was placed in room, if you want it to affect the created item you will have to get the returned id from instance_create:

ins=instance_create(o_player.x,o_player.y-10,o_46)

ins.solid=1
ins.depth=o_player.depth+1

if you make an array, where the first number is what you are doing and the second is the direction and you use numbers for the directions instead of strings, then your codes could be simplified a bit, for example:

create

face_dir=0; // 0 = rigth, 1 up, 2 left, 3 down
action=0; // what you are doing

a_carry = 0;
a_carry_run = 1;

spr[0,0]=carryL
spr[0,1]=carryU
spr[0,2]=carryR
spr[0,3]=carryD

spr[1,0]=carry_runL
spr[1,1]=carry_runU
spr[1,2]=carry_runR
spr[1,3]=carry_runD

carry speed part of your code

if carrying=1{
  if spd=2{ action=a_carry; }
  if spd=4{ action=a_carry_run; }
}

// then the sprite change
sprite_index=spr[action,face_dir]

if you use a number for the direction, then it is also possible to create the item in the correct direction by just using one line for all directions:

instance_create(o_player.x + 10*( (face_dir=0)-(face_dir=2) ),o_player.y+ 10*( (face_dir=3)-(face_dir=1) ),o_46)

- enjoy ^^

[iphoneiv]

Hrm, if it's not the variables. Hrm.. how exactly does scr_checknear work?

scr_checknear:

var _c;
_c=argument0

if (_c.x=x and _c.y=y+16 and _c.face_dir = "up")
return (1)
if (_c.x=x and _c.y=y-16 and _c.face_dir = "down")
return (1)
if (_c.x=x-16 and _c.y=y and _c.face_dir = "right")
return (1)
if (_c.x=x+16 and _c.y=y and _c.face_dir = "left")
return (1)

return (0)

it must be pretty troublesome to help me, but really, thx!^^



EDIT:
you know, i jst found it!
i changed the instance create's x and y to
o_player.x,o_player.y+16 (the +16 is the number for all the instance_create, but just depending on where you're facing)

and it worked!
thanks for helping, i'm so happy XD

Edited by iphoneiv, 04 March 2012 - 04:29 AM.

[iphoneiv]

may I suggest that you just give all items that can be picked up the same parent item..

and instead of all the code in the item you can delete the item in front and store the object type and sprite in player, so that player just draw it at the rigth place depending on the action.. when placement action is done you create it in front and clear your variables.

instance_create(o_player.x,o_player.y-10,o_46)

o_46.solid=1
o_46.depth=o_player.depth+1

note that writing object_name.variable will affect only the first o_46 that was placed in room, if you want it to affect the created item you will have to get the returned id from instance_create:

ins=instance_create(o_player.x,o_player.y-10,o_46)

ins.solid=1
ins.depth=o_player.depth+1

if you make an array, where the first number is what you are doing and the second is the direction and you use numbers for the directions instead of strings, then your codes could be simplified a bit, for example:

create

face_dir=0; // 0 = rigth, 1 up, 2 left, 3 down
action=0; // what you are doing

a_carry = 0;
a_carry_run = 1;

spr[0,0]=carryL
spr[0,1]=carryU
spr[0,2]=carryR
spr[0,3]=carryD

spr[1,0]=carry_runL
spr[1,1]=carry_runU
spr[1,2]=carry_runR
spr[1,3]=carry_runD

carry speed part of your code

if carrying=1{
  if spd=2{ action=a_carry; }
  if spd=4{ action=a_carry_run; }
}

// then the sprite change
sprite_index=spr[action,face_dir]

if you use a number for the direction, then it is also possible to create the item in the correct direction by just using one line for all directions:

instance_create(o_player.x + 10*( (face_dir=0)-(face_dir=2) ),o_player.y+ 10*( (face_dir=3)-(face_dir=1) ),o_46)

- enjoy ^^

woaaaaaaaaaaahhhhhhhhhhhhhh, so many good ways to make it not clustered and messy!
thanks, i really owe you; you've helped me so many time :D
i'll go try it out